Add role to spin up a basic external postgresql database#1502
Open
ehelms wants to merge 2 commits intotheforeman:masterfrom
Open
Add role to spin up a basic external postgresql database#1502ehelms wants to merge 2 commits intotheforeman:masterfrom
ehelms wants to merge 2 commits intotheforeman:masterfrom
Conversation
Member
|
Why bother adding el7 support? The os of the db should have little to no influence on the result of the setup. |
Member
Author
I already had it written from a while ago :D And I (think) I wanted to test an EL7 scenario. We can rip it out. |
40b09fd to
a87b521
Compare
Member
Author
|
This is ready for further review, I have added a variety of features to it as well to allow spinning up a database with either md5 or scram-sha-256. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pseudo-draft status. It could go in as is but I am hoping to take it for a spin against a Katello at least. My intent for this is to make it easier to test external database use cases (maybe pipeline it one day?).